Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use conda to install bmad in GitHub Actions #78

Merged
merged 8 commits into from
Jun 25, 2024

Conversation

ken-lauer
Copy link
Collaborator

  • Tests on Python 3.9-3.12
  • Installs bmad with conda

@ken-lauer
Copy link
Collaborator Author

2 failures, 111 passed - failures unexpected to me:

>           raise RuntimeError(f'Command: {cmd} causes error: {err}')
E           RuntimeError: Command: python beam 1 causes error: ERROR detected: [ERROR | 2024-JUN-20 20:59:34] tao_python_cmd:
E               "python beam 1": Out of range branch index
E           INVALID

pytao/tao_ctypes/core.py:157: RuntimeError
_______________________________ test_beam_init_1 _______________________________

    def test_beam_init_1():
    
        tao = Tao(os.path.expandvars('-init $ACC_ROOT_DIR/regression_tests/python_test/csr_beam_tracking/tao.init -noplot'))
>       ret = interface_commands.beam_init(tao, ix_uni='1')

pytao/tests/test_interface_commands.py:22: 

Is this because maybe the bmadmaster version vs the generated test suite differ? (@ChristopherMayes?)

@ChristopherMayes
Copy link
Contributor

master should be close to the release for this purpose.

@ken-lauer
Copy link
Collaborator Author

Closing/re-opening: retrying test suite to see if the unexpected errors magically go away 🤞

@ken-lauer ken-lauer closed this Jun 24, 2024
@ken-lauer ken-lauer reopened this Jun 24, 2024
@ken-lauer
Copy link
Collaborator Author

There were python command updates for tao: bmad-sim/bmad-ecosystem@7da7f46

@ChristopherMayes
Copy link
Contributor

I reported in bmad-sim/bmad-ecosystem#1016

@ken-lauer ken-lauer closed this Jun 25, 2024
@ken-lauer ken-lauer reopened this Jun 25, 2024
@ken-lauer
Copy link
Collaborator Author

This is reportedly fixed upstream; can you reapprove the GHA workflow @ChristopherMayes ?

@hhslepicka
Copy link
Collaborator

Approved @ken-lauer

@ken-lauer
Copy link
Collaborator Author

Thanks @hhslepicka !
Tests are now passing 🥳

@hhslepicka hhslepicka merged commit 5e9f02f into bmad-sim:master Jun 25, 2024
4 of 8 checks passed
@ken-lauer ken-lauer deleted the ci_use_conda branch June 25, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants