fix: replaceAsset returns the assetid #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks very good. I just went more or less nuts, because uploaded assets didn't show up in the Published Collection/Album. This was due to the fact, that the added assets were trashed. (I created an issue at the Immich repo) Thanks to your pull request, I now know why. :-) Many thanks :-) |
|
Oh, great, I'm glad I could help you. Speaking of PR in Immich: it would be good if your great plugin in Immich was mentioned in the community projects. Would love it if you could do a PR there. Your plugin really has a great status already!!! |
|
Thanks for the hint. I just sent a pull request :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently replaced images are not added to the album because the AssetId is wrong.
The Immich Replace-Asset API call does not return the AssetId but copiedPhoto.id (https://github.com/immich-app/immich/blob/aa04ded311985a6f8176217e47a7af89b7ea425d/server/src/services/asset-media.service.ts#L212), which doesn't make much sense from my point of view. But since we already know the AssetId, the AssetId is simply returned again.