Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Wrong behavior of confirmation dialog for delete images #40

Closed
bmachek opened this issue Oct 1, 2024 · 1 comment · Fixed by #41
Closed

[Bug] Wrong behavior of confirmation dialog for delete images #40

bmachek opened this issue Oct 1, 2024 · 1 comment · Fixed by #41
Assignees
Labels
bug Something isn't working

Comments

@bmachek
Copy link
Owner

bmachek commented Oct 1, 2024

Ability to delete assets in Immich when "unpublished" in Lightroom!

Nice!
I've tested this release thoroughly, and It's not quite reacting the way I was expecting. I might be miss-interpreting some functionalities, however.

Here is how I've tested it:
In lightroom, when I add an image to an Immich Publisher album (examble: "Test" Album), I have the ability to "Publish". This image is added to my Immich homepage, and to a newly created album in Immich called "Test". As expected.
When I delete this image from lightroom Immich Publisher, and hit "Publish", I get the prompt "Should removed photos be trashed in Immich?".
If I hit "Yes (Dangerous)", it deletes it from the "Test" Album, but not from my homepage which also mean it doesn't go in the trash either.
I was expecting it to get moved to the trash no matter what, and remove from all albums.
If I hit "If not included in any Album", it deletes it from the "Test" Album, and puts the image in the trash, which doesn't appear in the homepage either.
If I also include this image in a different album (Album "ABC" and "Test"), and I use the "If not included in any Album", it will delete it from All albums, and move the image to the trash.
It seems like "Yes (Dangerous)" and "If not included in any Album" are reverse? It's not quite clear.

Originally posted by @oflaki in #37 (comment)

@bmachek bmachek changed the title Wrong behavior of confirmation dialog for delete images [Bug] Wrong behavior of confirmation dialog for delete images Oct 1, 2024
@bmachek bmachek self-assigned this Oct 1, 2024
@bmachek bmachek added the bug Something isn't working label Oct 1, 2024
@bmachek bmachek moved this to In progress in Immich plugin TODO Oct 1, 2024
@bmachek
Copy link
Owner Author

bmachek commented Oct 1, 2024

You're right. Thanks for your detailed test. This made a lot easier. :-)

bmachek added a commit that referenced this issue Oct 1, 2024
@bmachek bmachek moved this from In progress to In review in Immich plugin TODO Oct 1, 2024
@bmachek bmachek linked a pull request Oct 1, 2024 that will close this issue
bmachek added a commit that referenced this issue Oct 1, 2024
…ion-dialog-for-delete-images

Bugfix for issue #40
@github-project-automation github-project-automation bot moved this from In review to Done in Immich plugin TODO Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant