Add filename filter for performance gain #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro-psb
commented
May 13, 2024
| utils.normalize_url("assets/javascripts/"), page.url | ||
| # No tags found, we can return earlier | ||
| if len(swagger_ui_list) == 0: | ||
| return output |
There was a problem hiding this comment.
The whole block down this change is just un-indented.
The diff is a bit weird on that, sorry.
pedro-psb
force-pushed
the
add-filename-filter-option
branch
from
7145cf5 to
ade0f07
Compare
pedro-psb
commented
May 16, 2024
|
I've added a test and reviewed the failing ones. |
blueswen
approved these changes
May 23, 2024
| utils.normalize_url("assets/javascripts/"), page.url | ||
| # No tags found, we can return earlier | ||
| if len(swagger_ui_list) == 0: | ||
| return output |
blueswen
reviewed
May 23, 2024
| @@ -56,6 +65,10 @@ class SwaggerUIPlugin(BasePlugin): | |||
| ("validatorUrl", config_options.Type(str, default="none")), | |||
| ("extra_css", config_options.Type(list, default=[])), | |||
| ("dark_scheme_name", config_options.Type(str, default="slate")), | |||
| ( | |||
| "filter_files", | |||
There was a problem hiding this comment.
I renamed the option to filter_files. I think using the file path is less ambiguous.
There was a problem hiding this comment.
What about marking files on the markdown frontmatter? (see here) The frontmatter data is already available in the page event hooks. I didn't though about that before, but it feels more ergonomic in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
closes: #25