Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove branching imports for Python <3.9 #876

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove branching imports for Python <3.9 #876

wants to merge 2 commits into from

Conversation

DiamondJoseph
Copy link
Contributor

@DiamondJoseph DiamondJoseph commented Feb 3, 2025 •
edited
Loading

As support for python < 3.9 has been dropped, removed the branching imports for versions < 3.9.

This allows defining a type hint for tree in build_app: of Mapping[str, Any]

It may also be possible to make the FastAPI instance app generic[T] on Mapping[str, T]?

Checklist

  • Add a Changelog entry
  • Add the ticket number which this PR closes to the comment section

@danielballan
Copy link
Member

Can you expand on this?

It may also be possible to make the FastAPI instance app generic[T] on Mapping[str, T]?

I'm not following, but it's likely because I am at PSI and jet-lagged. :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielballan danielballan danielballan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DiamondJoseph @danielballan