Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable router events #7735

Merged
merged 2 commits into from
Feb 14, 2025
Merged

Reenable router events #7735

merged 2 commits into from
Feb 14, 2025
+8 −5

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Feb 13, 2025 •
edited
Loading

DO NOT MERGE UNTIL MIDDLEMAN IS READY

Reenables router:navigate, except not sent to statsig using lake: prefix

Sends the previous and next route.

Test plan

Replace logEvent with console.log, confirm it looks good

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

Old size New size Diff
7.02 MB 7.02 MB 85 B (0.00%)

@arcalinea arcalinea temporarily deployed to samuel/reenable-router-events - social-app PR #7735 February 14, 2025 15:15 — with Render Destroyed
@mozzius
Copy link
Member Author

mozzius commented Feb 14, 2025

Realised logEvent adds a routeName field to all events anyway, so we don't need the to field

@haileyok
Copy link
Contributor

ready to go!

@mozzius mozzius merged commit 1161684 into main Feb 14, 2025
7 checks passed
@mozzius mozzius deleted the samuel/reenable-router-events branch February 14, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estrattonbailey estrattonbailey estrattonbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mozzius @haileyok @estrattonbailey @arcalinea