-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logger improvements #7729
Draft
estrattonbailey
wants to merge
16
commits into
main
Choose a base branch
from
logger-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Logger improvements #7729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements some long overdue updates to the logger. There are only a few functional changes.
Debug context has been reimplemented
This was vestigial from a previous project I used this logger on, and we never used it here at Bluesky. But there is utility here, so this PR migrates the existing
logger.DebugContext.*
3rd param setup to something more reasonable:This "context" shows up as labels in Sentry to better understand where logs originated, as well as show up in the console for easier debugging. It can also be used via
LOG_DEBUG
which will filter all debug logs except those that match the filter.This context is also entirely optional, and existing usages of
import {logger} from '#/logger'
use the default contextlogger
.Re-organizes logger files
Transports are now in
/transports
, all types in/types
, etc.Enables Sentry on web only, never loads on native
To that end, I co-located Sentry files in
#/logger/sentry
. ThesentryTransport
is conditionally applied on web only. I left the native interface, as it's the same library anyway, and who knows, we may want it in the future.Updates Sentry logs to use "context"
This will show up as labels on breadcrumbs, and as
(<context>) <message>
in results ofcaptureMessage
for quicker scanning.Added some fun colors to console logs (dev only)
Wanted to make logs a little easier to scan, esp on native when they stream back in your terminal without any formatting.
If any extra metadata is passed, the logs appear as a collapsed group to keep things tidy. On native it looks less good, but still a little better than we had before.