Per-user search history #7588
Open
Per-user search history #7588
+138
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I just realized that Bluesky was on github and came to look into adding this exact feature. So happy to see a PR open already! |
There was a problem hiding this comment.
Nice, love this! Couple thoughts while we're at it:
- I'd like to avoid random strings for storage and converge around using
#/storageinterface if possible, lmk what you think of that, can chat in Slack - The
#/storageinterface is sync, which doesn't help here much, but makes stuff a little simpler - Could pry pull this out into a hook just for code clarity, can live in this file for now
mozzius
force-pushed
the
samuel/per-user-search-history
branch
from
9bd94a5 to
7d3ffe3
Compare
arcalinea
temporarily deployed
to
samuel/per-user-search-history - social-app PR #7588
Render
Destroyed
arcalinea
temporarily deployed
to
samuel/per-user-search-history - social-app PR #7588
Render
Destroyed
arcalinea
temporarily deployed
to
samuel/per-user-search-history - social-app PR #7588
Render
Destroyed
mozzius
force-pushed
the
samuel/per-user-search-history
branch
from
25f24c7 to
663c8c9
Compare
estrattonbailey
approved these changes
Feb 6, 2025
| @@ -90,6 +97,7 @@ export function useProfilesQuery({handles}: {handles: string[]}) { | |||
| const res = await agent.getProfiles({actors: handles}) | |||
| return res.data | |||
| }, | |||
| placeholderData: maintainData ? keepPreviousData : undefined, | |||
There was a problem hiding this comment.
Oh didn't know they had a helper, v nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the search history to partition the history by DID, so that history is unique to the logged-in account
I also changed it to use
react-query, since that's better for handling async statethe new MMKV storage!Test plan
Generate some search history
Switch to and from accounts to confirm it's partitioned