Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lex: actor view semantics #724

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Lex: actor view semantics #724

merged 3 commits into from
Mar 28, 2023

Conversation

dholms
Copy link
Collaborator

@dholms dholms commented Mar 28, 2023

This renames actor.def#withInfo & standardizes on 3 different profile view options:

  • #profileViewBasic: previous #withInfo. used in feeds & search when we don't want to be too verbose
  • #profileView: also includes description & indexedAt time. used in lists of accounts like getLikes, getFollows, etc
  • #profileViewDetailed: full profile info. used in getProfile & getProfiles

@dholms dholms changed the base branch from main to lex-refactor March 28, 2023 00:19
@dholms dholms marked this pull request as ready for review March 28, 2023 00:24
@dholms dholms mentioned this pull request Mar 28, 2023
Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@dholms dholms merged commit b644065 into lex-refactor Mar 28, 2023
@dholms dholms deleted the lex/actor-views branch March 28, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants