Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lexicon: remove follows of scenes #718

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Lexicon: remove follows of scenes #718

merged 1 commit into from
Mar 27, 2023

Conversation

devinivy
Copy link
Collaborator

@devinivy devinivy commented Mar 25, 2023 •
edited
Loading

Removes follows of scene records. I used a static list here since it's short, it's fixed, and the actorType information would be dropped from the db before running the app migration unless we wanted to do some special coordination around that.

@devinivy devinivy mentioned this pull request Mar 25, 2023
Merged
dholms
dholms approved these changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aw sweet tbh i was just gonna let this one slip but stoked that you did it. hardcoding the scenes made a lot of sense as an approach. good call 🙏

@devinivy devinivy merged commit e70a904 into lex-refactor Mar 27, 2023
@devinivy devinivy deleted the lex/remove-scene-follows branch March 27, 2023 19:52
@dholms dholms mentioned this pull request Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dholms dholms dholms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinivy @dholms