Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexicon: standardize record repo interfaces #717

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

devinivy
Copy link
Collaborator

This unifies all the com.atproto.repo.* xrpc methods so that the repo to read/write to is specified with a repo field, which can be an at-identifier (i.e. did or handle). Previously the write endpoints instead took a did field as an input, while the read endpoints a repo.

@devinivy devinivy changed the title Lexicon: standard record repo interface Lexicon: standardize record repo interfaces Mar 25, 2023
@devinivy devinivy mentioned this pull request Mar 25, 2023
@pfrazee
Copy link
Collaborator

pfrazee commented Mar 27, 2023

LGTM, thanks for hitting this

Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup yup looks good 👍

@devinivy devinivy merged commit a343768 into lex-refactor Mar 27, 2023
@devinivy devinivy deleted the lex/std-record-repo-interface branch March 27, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants