Sync revamp migration fix #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Jan 31, 2023
dholms
force-pushed
the
sync-revamp-migration-fix
branch
from
3ac7986 to
9942ac2
Compare
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* moved indexedAt time to record instead of ipld-block * add in necessary ipld_block_creators * fix test name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue from the migration in #446
The issue we ran into was that block ownership was not being correctly tracked. There were some blocks that were only tied to the first user to create them & then not tracked for other users.
This fix tries to grab all the blocks tied to a user but then can dynamically ask for blocks not tied to the user if it needs to. It then does the migration as before, but also creates a link in
ipld_block_creatorfor each of those blocks.Relies on #501