Sort "suggested follows" by number of posts #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Jan 20, 2023
Comment on lines
105
to
106
| return { | ||
| primary: parseInt(cursor.primary), |
There was a problem hiding this comment.
It's annoying, but we might consider a check on whether cursor.primary parses to a number. Otherwise most random cursor strings sent-up here will probably get turned into 500s rather than 400s. In other places I have something like this:
if (isNaN(parsed)) {
throw new InvalidRequestError('Malformed cursor')
}There was a problem hiding this comment.
ah nice good call 👌
dholms
added a commit
that referenced
this pull request
Jan 24, 2023
* return suggestions by post count * pr feedback * fix up PG pagination issue
dholms
added a commit
that referenced
this pull request
Jan 27, 2023
* wip * fleshing out repo storage * fleshing out sql storage * cleaning things up * fix up tests * dumb bug - commit log reversed * rm staging in favor of commiting diffs to blockstore * clean up benches * fixing up sql storage * some caching for sql repo store * pr feedback * migration * wip * migraiton test * unclear param * sql repo storage tests * rm unused code * fix up some diff code * pr feedback * enum for action types * missed some * wip * ripping out auth lib * more auth cleanup * another lurker * wip better sync primitives * wip * improving diffs & sync * tests working! * actually implemented checkout lol * simplify interface & improve error handling * writing sql storage code * fixing up tests * testing & bugfixes * checkouts return records instead of cids * one last refactor lol * missed one * handle other cid codecs on incoming car verification * tests + tricky bugs * unneeded blockstore method * trim mst on del instead of save * cleanup comment * dont resolve did for every commit * use "commit" instead of "root" * getRoot -> getHead * pr feedback * very silly bug fix * improve sync output * reorging + sync of particular records * serve & verify proofs. also rename some ipld methods * fix up sync issue in mst * find reachable records form carfile * getRecord xrpc method * pr feedback * better migration test * check migraiton result * fixing up a couple things for pg * explicit migrateTo * async exceptions * ipld car mimetype + remove updateRepo * Update module publish scripts (#478) * Update pds package publishing scripts * Update auth package publishing scripts * Update crypto package publishing scripts * Update did-resolver package publishing scripts * Update handle package publishing scripts * Update xrpc-server package publishing scripts * Update common package publishing scripts * Update plc package publishing scripts * Update uri package publishing scripts * Update repo package publishing scripts * Sort "suggested follows" by number of posts (#477) * return suggestions by post count * pr feedback * fix up PG pagination issue * partiion commit-history & commit-blocks by user did * fix migration type * switch pk indexes Co-authored-by: Paul Frazee <pfrazee@gmail.com>
dholms
added a commit
that referenced
this pull request
Feb 2, 2023
* wip * fleshing out repo storage * fleshing out sql storage * cleaning things up * fix up tests * dumb bug - commit log reversed * rm staging in favor of commiting diffs to blockstore * clean up benches * fixing up sql storage * some caching for sql repo store * pr feedback * migration * wip * migraiton test * unclear param * sql repo storage tests * rm unused code * fix up some diff code * pr feedback * enum for action types * missed some * wip * ripping out auth lib * more auth cleanup * another lurker * wip better sync primitives * wip * improving diffs & sync * tests working! * actually implemented checkout lol * simplify interface & improve error handling * writing sql storage code * fixing up tests * testing & bugfixes * checkouts return records instead of cids * one last refactor lol * missed one * handle other cid codecs on incoming car verification * tests + tricky bugs * unneeded blockstore method * trim mst on del instead of save * cleanup comment * dont resolve did for every commit * use "commit" instead of "root" * getRoot -> getHead * pr feedback * very silly bug fix * improve sync output * reorging + sync of particular records * serve & verify proofs. also rename some ipld methods * fix up sync issue in mst * find reachable records form carfile * getRecord xrpc method * pr feedback * better migration test * check migraiton result * fixing up a couple things for pg * explicit migrateTo * async exceptions * ipld car mimetype + remove updateRepo * Update module publish scripts (#478) * Update pds package publishing scripts * Update auth package publishing scripts * Update crypto package publishing scripts * Update did-resolver package publishing scripts * Update handle package publishing scripts * Update xrpc-server package publishing scripts * Update common package publishing scripts * Update plc package publishing scripts * Update uri package publishing scripts * Update repo package publishing scripts * Sort "suggested follows" by number of posts (#477) * return suggestions by post count * pr feedback * fix up PG pagination issue * partiion commit-history & commit-blocks by user did * some lexicons reworking routes request deletion flows delete actor rows migration for user-partitioned-cids move creator to be on ipld_block migration tests * delete records & repos * delete blobs * hook it up in route * pettier ignore email templates * testing & bugfixes * testing blobs & bugfixes * pr feedback * make deletion test more robust * change out handle for did on account deletion * small cleanup --------- Co-authored-by: Paul Frazee <pfrazee@gmail.com>
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* return suggestions by post count * pr feedback * fix up PG pagination issue
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* wip * fleshing out repo storage * fleshing out sql storage * cleaning things up * fix up tests * dumb bug - commit log reversed * rm staging in favor of commiting diffs to blockstore * clean up benches * fixing up sql storage * some caching for sql repo store * pr feedback * migration * wip * migraiton test * unclear param * sql repo storage tests * rm unused code * fix up some diff code * pr feedback * enum for action types * missed some * wip * ripping out auth lib * more auth cleanup * another lurker * wip better sync primitives * wip * improving diffs & sync * tests working! * actually implemented checkout lol * simplify interface & improve error handling * writing sql storage code * fixing up tests * testing & bugfixes * checkouts return records instead of cids * one last refactor lol * missed one * handle other cid codecs on incoming car verification * tests + tricky bugs * unneeded blockstore method * trim mst on del instead of save * cleanup comment * dont resolve did for every commit * use "commit" instead of "root" * getRoot -> getHead * pr feedback * very silly bug fix * improve sync output * reorging + sync of particular records * serve & verify proofs. also rename some ipld methods * fix up sync issue in mst * find reachable records form carfile * getRecord xrpc method * pr feedback * better migration test * check migraiton result * fixing up a couple things for pg * explicit migrateTo * async exceptions * ipld car mimetype + remove updateRepo * Update module publish scripts (bluesky-social#478) * Update pds package publishing scripts * Update auth package publishing scripts * Update crypto package publishing scripts * Update did-resolver package publishing scripts * Update handle package publishing scripts * Update xrpc-server package publishing scripts * Update common package publishing scripts * Update plc package publishing scripts * Update uri package publishing scripts * Update repo package publishing scripts * Sort "suggested follows" by number of posts (bluesky-social#477) * return suggestions by post count * pr feedback * fix up PG pagination issue * partiion commit-history & commit-blocks by user did * fix migration type * switch pk indexes Co-authored-by: Paul Frazee <pfrazee@gmail.com>
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
* wip * fleshing out repo storage * fleshing out sql storage * cleaning things up * fix up tests * dumb bug - commit log reversed * rm staging in favor of commiting diffs to blockstore * clean up benches * fixing up sql storage * some caching for sql repo store * pr feedback * migration * wip * migraiton test * unclear param * sql repo storage tests * rm unused code * fix up some diff code * pr feedback * enum for action types * missed some * wip * ripping out auth lib * more auth cleanup * another lurker * wip better sync primitives * wip * improving diffs & sync * tests working! * actually implemented checkout lol * simplify interface & improve error handling * writing sql storage code * fixing up tests * testing & bugfixes * checkouts return records instead of cids * one last refactor lol * missed one * handle other cid codecs on incoming car verification * tests + tricky bugs * unneeded blockstore method * trim mst on del instead of save * cleanup comment * dont resolve did for every commit * use "commit" instead of "root" * getRoot -> getHead * pr feedback * very silly bug fix * improve sync output * reorging + sync of particular records * serve & verify proofs. also rename some ipld methods * fix up sync issue in mst * find reachable records form carfile * getRecord xrpc method * pr feedback * better migration test * check migraiton result * fixing up a couple things for pg * explicit migrateTo * async exceptions * ipld car mimetype + remove updateRepo * Update module publish scripts (bluesky-social#478) * Update pds package publishing scripts * Update auth package publishing scripts * Update crypto package publishing scripts * Update did-resolver package publishing scripts * Update handle package publishing scripts * Update xrpc-server package publishing scripts * Update common package publishing scripts * Update plc package publishing scripts * Update uri package publishing scripts * Update repo package publishing scripts * Sort "suggested follows" by number of posts (bluesky-social#477) * return suggestions by post count * pr feedback * fix up PG pagination issue * partiion commit-history & commit-blocks by user did * some lexicons reworking routes request deletion flows delete actor rows migration for user-partitioned-cids move creator to be on ipld_block migration tests * delete records & repos * delete blobs * hook it up in route * pettier ignore email templates * testing & bugfixes * testing blobs & bugfixes * pr feedback * make deletion test more robust * change out handle for did on account deletion * small cleanup --------- Co-authored-by: Paul Frazee <pfrazee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #476