PDS proxy to appview performance #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Sep 3, 2024
| return nodeCrypto.createPrivateKey(privKeyEncoded) | ||
| } | ||
|
|
||
| describe('entryway auth', () => { |
There was a problem hiding this comment.
Testing expiration could be nice too!
devinivy
approved these changes
Sep 3, 2024
Vincentroland
approved these changes
Sep 5, 2024
Vincentroland
approved these changes
Sep 5, 2024
| } | ||
|
|
||
| const res = await jose | ||
| .jwtVerify(token, this.entrywayJwtPublicKey) |
There was a problem hiding this comment.
For good measure, we should ensure that the right issuer is used, even if this should already be covered by the fact that entrywayJwtPublicKey is specific to entryway.
Maybe the payload's iss can be used to determine if this method should be used (in standardOptionalParameterized)
Suggested change
| .jwtVerify(token, this.entrywayJwtPublicKey) | |
| .jwtVerify(token, this.entrywayJwtPublicKey, { iss: ... }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a temporary measure where a PDS can proxy directly through to the appview without signing a service auth header. This is mean to reduce load on Bluesky PDS instances, and is not intended to be implemented by other Appviews in the network. While this is a bit awkward, it is directionally aligned with possible plans to have the client talk directly to the Appview.