Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update email templates #2767

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Update email templates #2767

merged 7 commits into from
Sep 12, 2024

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Aug 30, 2024

These emails are generated with https://react.email, and a small custom script to output .hbs templates. Preview variables are replaced with {{ var }} syntax.

Only functional change is that reset-password how accepts a handle instead of identifier, so that the templates match our entryway.

Before/after

Confirm email

CleanShot 2024-08-30 at 15 05 13@2x
CleanShot 2024-08-30 at 15 05 23@2x

Delete account

CleanShot 2024-08-30 at 15 06 00@2x
CleanShot 2024-08-30 at 15 05 55@2x

PLC update operation

Was a little unsure on wording here, unsure when this is used.
CleanShot 2024-08-30 at 15 06 26@2x
CleanShot 2024-08-30 at 16 39 54@2x

Reset password

CleanShot 2024-08-30 at 15 06 59@2x
CleanShot 2024-08-30 at 15 06 52@2x

Update email

CleanShot 2024-08-30 at 15 07 32@2x
CleanShot 2024-08-30 at 15 07 26@2x

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG. I think the only tweak is the plc operation needs to specify that you're seeing the confirmation code

@estrattonbailey
Copy link
Member Author

Updated, updated screenshot:

We received a request to update your PLC. Your confirmation code is:

@heikadog
Copy link

@estrattonbailey at least on my end i've seen the PLC email when i set up my labeler and i have 2FA on
Screenshot_20240831-125136

Copy link
Collaborator

@dholms dholms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incredible. beautiful. worthy of praise.

@dholms dholms merged commit 922b94c into main Sep 12, 2024
10 checks passed
@dholms dholms deleted the email-templates branch September 12, 2024 15:53
@github-actions github-actions bot mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants