✅ fix(xrpc-server): properly parse & process content-encoding #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
force-pushed
the
fix-content-encoding
branch
from
ac67843
to
cf04e48
Compare
matthieusieben
changed the title
matthieusieben
force-pushed
the
fix-content-encoding
branch
3 times, most recently
from
2eaf59c
to
14dbb29
Compare
matthieusieben
force-pushed
the
fix-content-encoding
branch
from
14dbb29
to
8cf9f1b
Compare
matthieusieben
commented
Sep 10, 2024
Comment on lines
-266
to
-269
| if (input?.body instanceof Readable) { | ||
| // If the body stream errors at any time, abort the request | ||
| input.body.once('error', next) | ||
| } |
There was a problem hiding this comment.
This line breaks Express' flow control. Indeed, when the stream is being consumed, the consumer might will also catch that error. The consumer can then decide to do multiple things:
- call
next()ornext(err) - handle the error and write to the response
in any case, the error listener here will not "abort" the request, but only trigger the next error middleware, and will cause that error middleware to be called while the body consumer might try to do stuff with the response.
dholms
reviewed
Sep 10, 2024
| finishFlush: zlib.constants.Z_SYNC_FLUSH, | ||
| }) | ||
| case 'deflate': | ||
| return zlib.createInflate() |
There was a problem hiding this comment.
oh nice snag on switching that out
dholms
reviewed
Sep 10, 2024
dholms
reviewed
Sep 10, 2024
| { | ||
| encoding: 'application/octet-stream', | ||
| headers: { | ||
| 'content-encoding': 'gzip, identity, deflate, identity, br, identity', |
dholms
approved these changes
Sep 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
content-encoding can contain multiple values (comma separated).
createDeflateinstead ofcreateInflateto decompress bytes encoded using thedeflatealgo. This PR changes that.content-lengthheaders that are not a number. This PR ensures that the parsing of the number did not result inNaN.