Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make requestCrawl & notifyOfUpdate procedures #1217

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

dholms
Copy link
Collaborator

@dholms dholms commented Jun 19, 2023

re: #1214

Because these are intended to have side effects they really should be POSTs instead of GETs.

Rollout plan: we're intending to support both POSTs & GETs on BGS for some period - likely a week - as this change goes out, then we will be deprecating GETs

Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good!

@dholms dholms merged commit 2768fb9 into main Jun 20, 2023
6 checks passed
@dholms dholms deleted the request-crawl-procedure branch June 20, 2023 14:36
dholms added a commit that referenced this pull request Jun 22, 2023
make requestCrawl & notifyOfUpdate procedures
mloar pushed a commit to mloar/atproto that referenced this pull request Sep 26, 2023
make requestCrawl & notifyOfUpdate procedures
mloar pushed a commit to mloar/atproto that referenced this pull request Nov 15, 2023
make requestCrawl & notifyOfUpdate procedures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants