specs: v3 commit prev as nullable but non-optional #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnewbold
requested review from
dholms,
devinivy,
whyrusleeping and
ericvolp12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve compatibility issues with "nullable and optional" fields in this core data structure with golang.
Background here: bluesky-social/indigo#327
Basically signatures fail to validate in golang if the field is not included but
null.It would have been possible to just remove this field from the spec, or have it be optional (but not nullable) and those would have worked fine with golang, but the boat has basically sailed (tons of existing data in this format). So we'll stick with requiring the field exist, but be nullable.