772 we should allow users to watch recorded videos (or parts of it) in the video view #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturoManzoli
requested review from
patrickelectric,
Williangalvani and
JoaoMario109
patrickelectric
requested changes
Mar 27, 2024
There was a problem hiding this comment.
There are a couple of problems in the commit organization.
On your first commit you are adding VideoPlayer and modifying bun and package.js, the same thing applyis on 64943fe and 77e2486.
Commits should be atomic and self-contained.
To fix that, check stash, fixup, rebase and also absorb.
ArturoManzoli
force-pushed
the
772-We-should-allow-users-to-watch-recorded-videos-(or-parts-of-it)-in-the-video-view
branch
from
b5b1413 to
a1aeeec
Compare
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
…ed content table Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
Signed-off-by: Arturo Manzoli <arturomanzoli@gmail.com>
ArturoManzoli
force-pushed
the
772-We-should-allow-users-to-watch-recorded-videos-(or-parts-of-it)-in-the-video-view
branch
from
a1aeeec to
6134139
Compare
patrickelectric
approved these changes
Mar 31, 2024
|
Just tested it! Nice addition! |
ArturoManzoli
deleted the
772-We-should-allow-users-to-watch-recorded-videos-(or-parts-of-it)-in-the-video-view
branch
|
This will probably be obvious once the screenshot is updated, but just making a note that we should likely include it in a list of features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add video-js library and video player on a popover from the stored videos table;
Add some minor ui changes, expanding the clickable area that opens stored videos modal at the miniVideoPlayer widget;
Fix #772