Feature/docker update #59
Conversation
correct GST_MESON_OPTIONS and GST_BUILD_TOOLS to be array and not string
| @@ -267,9 +267,9 @@ EOF | |||
| fi | |||
|
|
|||
| GST_BUILD_DIR=builddir | |||
| meson setup ${GST_MESON_OPTIONS[@]} $GST_BUILD_DIR | |||
| meson setup "$GST_BUILD_DIR" "${GST_MESON_OPTIONS[@]}" | |||
There was a problem hiding this comment.
Does this work? The help says meson setup [args] [builddir] [sourcedir]
There was a problem hiding this comment.
The CI is green, maybe we should add tests to ensure the gst installation ?
There was a problem hiding this comment.
From the logs, meson receives those parameters correctly, so that works.
Regarding tests, we do have some tests to ensure (some) plugins are installed with no missing dynamic libraries in the inspect_gst_plugins.sh script.
There was a problem hiding this comment.
That's true, forgot about those
There was a problem hiding this comment.
Ha... The documents I read got the the parameters in the other order... I didnt' double check with the version used so maybe I am wrong on this.
It was building thus
There was a problem hiding this comment.
@joaoantoniocardoso meson docs is a bit confusing about this but on current version the syntax is this one.
The documentation example also state this on hints : https://mesonbuild.com/Running-Meson.html#configuring-the-build-directory
So it should be good
Reduce docker intermediate layer size
Improve rebuild with COPY --link
Add ccache cache usage for gstreamer build
improve shell scripts syntax and add linter
add linter for Dockerfile
enable linters checks on CI