Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hot reloading on Windows when letter case changes (#2585) #2586

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

jsbohnert
Copy link
Contributor

The current behavior of performing "evalSymlinks" on the "watchedPath" seems to lead to mismatches and ignored changes if the event-reported "eventPath" is not similarly processed on Windows.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2586 (b4048d7) into main (cde1909) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2586      +/-   ##
==========================================
- Coverage   59.85%   59.84%   -0.02%     
==========================================
  Files         145      145              
  Lines       15530    15531       +1     
==========================================
- Hits         9296     9295       -1     
- Misses       5591     5593       +2     
  Partials      643      643              
Files Coverage Δ
internal/confwatcher/confwatcher.go 79.22% <100.00%> (+0.27%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 changed the title evaluate confwatcher event paths to ensure consistency with stored path, fixes #2585 evaluate confwatcher event paths to ensure consistency with stored path, (#2585) Oct 28, 2023
@aler9 aler9 changed the title evaluate confwatcher event paths to ensure consistency with stored path, (#2585) fix hot reloading configuration on Windows when letter case changes (#2585) Oct 28, 2023
@aler9
Copy link
Member

aler9 commented Oct 28, 2023

Fixes #2585

@aler9 aler9 changed the title fix hot reloading configuration on Windows when letter case changes (#2585) fix hot reloading on Windows when letter case changes (#2585) Oct 28, 2023
@aler9
Copy link
Member

aler9 commented Oct 28, 2023

Hello, everything seems to be good. This has been merged. Thanks!

@aler9 aler9 merged commit 88dd8d2 into bluenviron:main Oct 28, 2023
@aler9
Copy link
Member

aler9 commented Oct 28, 2023

added in v1.2.1

@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants