Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: fix crash when retrieving RTMP and SRT connections (#2430) #2431

Merged
merged 1 commit into from
Sep 28, 2023
Merged

api: fix crash when retrieving RTMP and SRT connections (#2430) #2431

merged 1 commit into from
Sep 28, 2023

Conversation

p4xx07
Copy link
Contributor

@p4xx07 p4xx07 commented Sep 28, 2023

I fixed the issue I opened #2430

There was a variable name issue in the nil checks. Probably a typo. Please merge

@aler9 aler9 changed the title fix: fixed this issue #2430 api: fix crash when retrieving RTMP and SRT connections (#2430) Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #2431 (6c95748) into main (42aa979) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2431      +/-   ##
==========================================
+ Coverage   61.64%   61.66%   +0.02%     
==========================================
  Files         129      129              
  Lines       14497    14497              
==========================================
+ Hits         8936     8939       +3     
+ Misses       4890     4888       -2     
+ Partials      671      670       -1     
Files Coverage Δ
internal/core/rtmp_conn.go 70.63% <100.00%> (ø)
internal/core/srt_conn.go 55.21% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9
Copy link
Member

aler9 commented Sep 28, 2023

Grazie @Paxx-RnD e @Allan-Nava per aver segnalato e risolto il problema.

@aler9 aler9 merged commit 72e74b6 into bluenviron:main Sep 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants