Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support relative Content-Base paths #636

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

kevmo314
Copy link
Contributor

A camera I'm working with spits out Content-Base as a relative path instead of absolute. This change adds support for those by grafting in the scheme and host from the base URL if it appears to be a relative path.

@aler9
Copy link
Member

aler9 commented Oct 23, 2024

Hello, i understood the change and i think it can be merged, but can you write the name of the manufacturer and model of the camera? in this way we are keeping track of why we performed these kind of compatibility-related changes. Thanks.

@kevmo314
Copy link
Contributor Author

Hello, i understood the change and i think it can be merged, but can you write the name of the manufacturer and model of the camera? in this way we are keeping track of why we performed these kind of compatibility-related changes. Thanks.

Yep, this specific camera is a Hanwha Vision XNV-6011: https://hanwhavisionamerica.com/product/xnv-6011/

I assume there may be other models with the same behavior but at least that's the one I'm working with right now :)

@aler9 aler9 merged commit 21e06b0 into bluenviron:main Oct 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants