Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout on last Ping corrupts AvgResponseTime #9

Open
bhelterline opened this issue Jul 9, 2020 · 0 comments
Open

Timeout on last Ping corrupts AvgResponseTime #9

bhelterline opened this issue Jul 9, 2020 · 0 comments

Comments

@bhelterline
Copy link
Contributor

If the last ping received times out, the AvgResponseTime variable does not get properly calculated. It remains as the sum of all the previous response times and is never divided by the TotalReceivedResponses. This calculation is done in PingReceived() but needs to be duplicated in RequestTimeoutOccurred()
bhelterline added a commit to bhelterline/esp8266-ping that referenced this issue Jul 9, 2020
@bhelterline
Fixed issue bluemurder#9 - Timeout on last Ping corrupts AvgResponseTime
15c665c
bluemurder added a commit that referenced this issue Aug 5, 2022
@bluemurder
Merge pull request #10 from bhelterline/master
a9ab808 
Fixed issue #9 - Timeout on last Ping corrupts AvgResponseTime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bhelterline