RM-124: Add command to perform a healthcheck against airbyte server #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
naswierczek
commented
Feb 8, 2024
naswierczek
commented
- adds new optional arugment that can be passed to mvrec that will query the healthcheck endpoint on the configured airbyte instance and return either true or false depending on if that endpoint returns a 200 status code
- Added new class to support argument
- Added unit tests for new class method
naswierczek
commented
Feb 8, 2024
naswierczek
force-pushed
the
rm-124-airbyte-engine-healthcheck
branch
from
268b208
to
696dfa4
Compare
Brunope
reviewed
Feb 13, 2024
naswierczek
force-pushed
the
rm-124-airbyte-engine-healthcheck
branch
from
696dfa4
to
0928e5d
Compare
|
@Brunope This is just step one of an overall larger project to integrate airbyte as the engine for doing stuff. Anything else you'd want to see in this PR before it merges? I'm feeling like I should put in a basic feature flag where if you don't have an environment variable set, the new option doesn't even appear. |
naswierczek
force-pushed
the
rm-124-airbyte-engine-healthcheck
branch
4 times, most recently
from
ef1e934
to
3b1f4ef
Compare
Brunope
approved these changes
Feb 21, 2024
naswierczek
force-pushed
the
rm-124-airbyte-engine-healthcheck
branch
from
0607171
to
10b8129
Compare
naswierczek
force-pushed
the
rm-124-airbyte-engine-healthcheck
branch
from
10b8129
to
264c508
Compare
- adds new optional arugment that can be passed to mvrec that will query the healthcheck endpoint on the configured airbyte instance and return either true or false depending on if that endpoint returns a 200 status code - adds "feature flag" so this can dark launch - Added new class to support argument - Added initial methods for retieving airbyte credentials - Added unit tests for new class method
naswierczek
force-pushed
the
rm-124-airbyte-engine-healthcheck
branch
from
264c508
to
e106732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.