Ezml 1226 versions semantic control #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if prevCrApp.Spec.Version == crApp.Spec.Version { | ||
| prevVer := semver.New(prevCrApp.Spec.Version) | ||
| newVer := semver.New(crApp.Spec.Version) | ||
|
|
There was a problem hiding this comment.
At this point, prevVer and/or newVer can be nil if the version string is not understood by semver. In those cases we should also reject the upgrade.
There was a problem hiding this comment.
Actually, my mistake. In those cases, New will panic, which is bad for us.
Try using NewVersion (instead of New) as in https://github.com/coreos/go-semver/blob/main/example.go
|
Also note that Travis CI is reporting that you need to run "make format". |
Fixed |
|
Nice. |
joel-bluedata
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #590