Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): fetch all refs to validate commit on main #22

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

chris-asl
Copy link
Collaborator

@chris-asl chris-asl commented Dec 1, 2023

  1. Use fetch-depth: 0 of checkout action to fetch all refs, as per this https://github.com/actions/checkout?tab=readme-ov-file#Fetch-all-history-for-all-tags-and-branches
  2. Finally, use git rev-parse origin/main since we don't have a local main branch ref.

Tested it works here. A failing pipeline, since the tag wasn't based on a commit merged in main ref.

@chris-asl chris-asl self-assigned this Dec 1, 2023
@chris-asl chris-asl force-pushed the chore/fix-release-fetch-all-refs-tags branch 2 times, most recently from e3b1d16 to b4d1a8d Compare December 1, 2023 13:48
Use `fetch-depth: 0` of checkout action to fetch all refs, as per this
https://github.com/actions/checkout?tab=readme-ov-file#Fetch-all-history-for-all-tags-and-branches

Finally, use `git rev-parse origin/main` since we don't have a local
`main` branch ref.

[no-jira]
@chris-asl chris-asl force-pushed the chore/fix-release-fetch-all-refs-tags branch from b4d1a8d to 20d3bb8 Compare December 1, 2023 13:51
Copy link
Collaborator

@ippokratoys ippokratoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏾

@chris-asl chris-asl merged commit 5f2f505 into main Dec 1, 2023
1 check passed
@chris-asl chris-asl deleted the chore/fix-release-fetch-all-refs-tags branch December 1, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants