-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add release pipeline #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daa7e7d
to
eaef4da
Compare
pavlospt
reviewed
Mar 23, 2023
e1c32d3
to
ca7276a
Compare
ca7276a
to
2357289
Compare
2e62874
to
3decf2d
Compare
ippokratoys
reviewed
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good 👌🏾
Just some minor comments
We can now release a new artifact by pushing a tag. In upcoming commits, this will be simplified to releasing upon a commit bumping the library version. [no-jira]
Due to the upgrade of the `com.vanniktech.maven.publish` plugin and our configuration, the release process has been simplified to a command. [no-jira]
3decf2d
to
c269904
Compare
ippokratoys
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏾
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add release pipeline, which is triggered via a tag push, builds the artifact and releases it to the OSSRH repository.
[no-jira]
TODO
To test this:
gradle core:publishToLocalMaven
0.4.4-SNAPSHOT
and the build succeededI'd like to test this with a PR in our own repo, so that online resolution works.