Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add release pipeline #13

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Conversation

chris-asl
Copy link
Collaborator

@chris-asl chris-asl commented Mar 22, 2023

Add release pipeline, which is triggered via a tag push, builds the artifact and releases it to the OSSRH repository.

[no-jira]


TODO

  • Update README with new publish instructions
  • (Will be tackled in upcoming PR) Tag => GH release => publish or upon release commit => tag => GH release => publish? 🤔

To test this:

  • I've built it locally and published it to my local M2 repo with
  • gradle core:publishToLocalMaven
  • changed the version in one of our library client repos, to 0.4.4-SNAPSHOT and the build succeeded

I'd like to test this with a PR in our own repo, so that online resolution works.

@chris-asl chris-asl self-assigned this Mar 22, 2023
@chris-asl chris-asl force-pushed the chore/no-jira-release-pipeline branch 4 times, most recently from daa7e7d to eaef4da Compare March 22, 2023 23:52
@chris-asl chris-asl force-pushed the chore/no-jira-release-pipeline branch 21 times, most recently from e1c32d3 to ca7276a Compare June 26, 2023 13:10
@chris-asl chris-asl force-pushed the chore/no-jira-release-pipeline branch from ca7276a to 2357289 Compare June 26, 2023 14:50
@chris-asl chris-asl changed the title [WIP] chore(ci): add release pipeline chore(ci): add release pipeline Jun 26, 2023
@chris-asl chris-asl marked this pull request as ready for review June 26, 2023 14:51
@chris-asl chris-asl force-pushed the chore/no-jira-release-pipeline branch from 2e62874 to 3decf2d Compare June 26, 2023 20:42
Copy link
Collaborator

@ippokratoys ippokratoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good 👌🏾
Just some minor comments

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
chris-asl added 4 commits July 6, 2023 09:31
We can now release a new artifact by pushing a tag.
In upcoming commits, this will be simplified to releasing
upon a commit bumping the library version.

[no-jira]
Due to the upgrade of the `com.vanniktech.maven.publish` plugin and
our configuration, the release process has been simplified to a command.

[no-jira]
@chris-asl chris-asl force-pushed the chore/no-jira-release-pipeline branch from 3decf2d to c269904 Compare July 6, 2023 06:31
Copy link
Collaborator

@ippokratoys ippokratoys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏾

@chris-asl chris-asl merged commit 01f56d0 into main Jul 6, 2023
@chris-asl chris-asl deleted the chore/no-jira-release-pipeline branch July 6, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants