fix: Improve Error handling for Unsupported Sources #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustl22
changed the title
spydon
approved these changes
Sep 27, 2023
packages/audioplayers/example/integration_test/lib/lib_source_test_data.dart
Show resolved
Hide resolved
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Gustl22
added a commit
that referenced
this pull request
Sep 29, 2023
# Description - feat: Improved error description for unsupported file formats - fix: Handle white space and special characters in URL and Assets (Web & Darwin) - test: Test files without file extension (not playable Darwin) ## Related Issues Closes #1494 Closes #748 Closes #972 Closes #1546 --------- Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com> (cherry picked from commit a4d8442)
Gustl22
added a commit
that referenced
this pull request
Nov 14, 2023
# Description - feat: Improved error description for unsupported file formats - fix: Handle white space and special characters in URL and Assets (Web & Darwin) - test: Test files without file extension (not playable Darwin) ## Related Issues Closes #1494 Closes #748 Closes #972 Closes #1546 --------- Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
fix:,feat:,refactor:,docs:,chore:,test:,ci:etc).///, where necessary.Breaking Change
Related Issues
Closes #1494
Closes #748
Closes #972
Closes #1546