Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(example): add invalid asset, small refactor, colored source buttons #1445

Merged
merged 2 commits into from
Mar 20, 2023
Merged

feat(example): add invalid asset, small refactor, colored source buttons #1445

merged 2 commits into from
Mar 20, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Mar 20, 2023

Description

  • Add invalid.txt as example asset to test playing invalid files
  • Refactor asset variable names to match the existing ones
  • Colored buttons in source tab

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs:, chore: etc).
  • I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in [example].

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Gustl22 Gustl22 requested a review from spydon March 20, 2023 15:33
@Gustl22 Gustl22 force-pushed the gustl22/example-invalid-asset branch from f00c3b3 to 5cd6115 Compare March 20, 2023 15:33
@Gustl22 Gustl22 merged commit 92a20fa into main Mar 20, 2023
@Gustl22 Gustl22 deleted the gustl22/example-invalid-asset branch March 20, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gustl22 @spydon