Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: player state, improved position & duration (#1257, #1298) #1284

Merged
merged 31 commits into from
Oct 5, 2022
Merged

test: player state, improved position & duration (#1257, #1298) #1284

merged 31 commits into from
Oct 5, 2022

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Sep 23, 2022 •
edited
Loading

Description

Tests for #1257 and #1298

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@Gustl22 Gustl22 marked this pull request as ready for review September 25, 2022 21:49
@Gustl22
Copy link
Collaborator Author

Gustl22 commented Sep 27, 2022

@luanpotter unfortunately I don't get logs for ios / macos. I think the problem is, that darwin implementation throws an error, when getDuration is called for live streams. This makes sense from the implementation perspektive. But I would prefer to not throw native errors and handle them all in audioplayers package. The other implementations return 0, in this case.

This was referenced Sep 27, 2022
Merged
Closed
@Gustl22 Gustl22 changed the title chore(tests): player state tests (#1258) chore(tests): player state tests (#1257) Oct 4, 2022
@Gustl22 Gustl22 mentioned this pull request Oct 4, 2022
Merged
7 tasks
spydon pushed a commit that referenced this pull request Oct 5, 2022
@Gustl22
fix(darwin): infinity / nan on getDuration (#1298)
a4474dc 
I decided to do a separate PR, as it doesn't really belong to the tests in #1284.
Avoid getting error when calling getDuration on darwin, when getting back infinity or NaN values.
@Gustl22 Gustl22 changed the title chore(tests): player state tests (#1257) test: player state, improved position & duration (#1257, #1298) Oct 5, 2022
@Gustl22 Gustl22 enabled auto-merge (squash) October 5, 2022 07:29
@Gustl22 Gustl22 merged commit 5dcc382 into main Oct 5, 2022
@Gustl22 Gustl22 deleted the 1258-playerState-tests branch October 5, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@luanpotter luanpotter Awaiting requested review from luanpotter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gustl22 @spydon