-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(windows, linux) : Added setBalance method #1248
Conversation
Nice 👍 I'd prefer to add the integration tests first in #1238 and then can add this feature to the example / tests, too. |
@novikov-studio Would you mind adding buttons to the example and adding tests, now that #1238 is merged. Need to rebase or merge |
@Gustl22, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work.
You also have to overwrite setBalance
in web implementation, otherwise the test will fail.
It would also be good to overwrite it in the other implementations (darwin, android) and throw an explicit unimplemented error or add a logger error, although it's not mandatory, but would give a better error message, what is not implemented yet.
Best regards
packages/audioplayers/example/integration_test/tabs/controls_tab.dart
Outdated
Show resolved
Hide resolved
packages/audioplayers/example/integration_test/tabs/controls_tab.dart
Outdated
Show resolved
Hide resolved
packages/audioplayers_platform_interface/lib/method_channel_audioplayers_platform.dart
Outdated
Show resolved
Hide resolved
Hi @novikov-studio, It also works for me, but You should try to work via JS interface: https://pub.dev/packages/js , but I never used it, so I cannot give you a promise that it will work. Regarding the crossOrigin flag, I also have no clue. It may solves itself when using JS interface 🤷 |
@novikov-studio somehow, the linux implementation works on my Ubuntu machine. But on my WSL2 via windows it give the error, which is also in the CI workflow:
Are we missing a package? I wonder if ALSA plays a role here. |
setBalance uses GStreamer's audiopanorama plugin, which is in "GStreamer Good Plug-ins" package. |
sorry, that's not the problem. It's also installed via the workflow. I'll try to figure it out tomorrow, if you can't reproduce it right now :) |
FYI: @novikov-studio I also reworked the web implementation in this branch, but the cors flag is still needed. |
Sorry, I never used WSL2, so I can't reproduce. |
I now used autoaudiosink following this tutorial: https://gstreamer.freedesktop.org/documentation/tutorials/playback/custom-playbin-sinks.html?gi-language=c |
Description
Added method:
Platforms
Windows - yes
Linux - yes
Related Issues
closes #58