Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re2 (used by get-urls package) takes 2 minutes to install? #134

Closed
claytercek opened this issue Sep 28, 2023 · 2 comments · Fixed by #147
Closed

re2 (used by get-urls package) takes 2 minutes to install? #134

claytercek opened this issue Sep 28, 2023 · 2 comments · Fixed by #147
Labels
bug Something isn't working #content

Comments

@claytercek
Copy link
Member

The package re2 takes 2+ minutes to install, noticeable on mac and windows. We're using it via the get-urls package in launchpad content, maybe we should look into an alternative that doesn't use re2?

@claytercek claytercek added bug Something isn't working #content labels Sep 28, 2023
@benjaminbojko
Copy link
Collaborator

Thanks for identifying that! I'm definitely open to exploring alternatives. We haven't used custom JSON endpoints in a while, but I'd want to make sure that whatever alternative we find is somewhat en-par with get-urls. I'm open to that being just a really good regex, that maybe could be customized via options.

@claytercek
Copy link
Member Author

looks like they moved off of re2 in get-urls 4.0.0

claytercek added a commit that referenced this issue Jun 18, 2024
claytercek added a commit that referenced this issue Jun 18, 2024
This was referenced Jun 18, 2024
@claytercek claytercek linked a pull request Jun 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working #content
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants