Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass on view animation helper class and sample #31

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kevinzak
Copy link
Contributor

@kevinzak kevinzak commented Aug 2, 2016

Ben and I added some FadeIn and FadeOut methods and created a base structure. We wanted to have a further conversation about naming and where the animation helper classes should live.

@benjaminbojko
Copy link
Collaborator

benjaminbojko commented Aug 5, 2016

I think this is a great start. As discussed, a few questions we should resolve before merging this in:

  • Namespace + folder (high priority): The class currently lives in src/utils, but that is confusing with the bluecadet::utils namespace
  • Class name (low priority): We both mentioned that ViewAnimations might not be the best fit. Can we come up with something more fitting?

Aside from these two I'd say it would be good to merge in, @kevinzak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants