Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[libc++] Remove usage of internal string function in sstream (#75858)
This function replaces a call to `__move_assign` (internal function) with two calls to public member functions (`resize` and `erase`). The order of calls is chosen for the best performance. This change is required to [turn on ASan string annotations for short strings](llvm/llvm-project#75882) (Short String Optimization - SSO). The `std::basic_string` class's `void __move_assign(basic_string&& __str, size_type __pos, size_type __len)` function operates on uninitialized strings, where it is reasonable to assume that the memory is not poisoned. However, in `sstream` this function is applied to existing strings that already have poisoned memory. String ASan annotations turned on here: llvm/llvm-project#72677 NOKEYCHECK=True GitOrigin-RevId: 5351ded68d579921a61b26a34e36046c22f668bd
- Loading branch information