Skip to content

Commit

Permalink
Revert "Remove NotEnumerable from Transform Streams WebIDL"
Browse files Browse the repository at this point in the history
This reverts commit b52b97c.

Reason for revert: It is breaking external/wpt/streams/idlharness.any.html based on bisection.

Original change's description:
> Remove NotEnumerable from Transform Streams WebIDL
>
> According to whatwg/streams#1035, all methods
> and accessors are now enumerable, per Web IDL defaults, instead of
> non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can
> be removed from the Streams WebIDL files. This CL specifically
> removes them from transform streams.
>
> Bug: 1093862
> Change-Id: I509b470722039ebad20b8caeaa7f34189c24b1ba
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486006
> Commit-Queue: Nidhi Jaju <nidhijaju@google.com>
> Reviewed-by: Adam Rice <ricea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#819230}

TBR=ricea@chromium.org,nidhijaju@google.com

Change-Id: I7176391031e4bbf89960fe6d7f358a520d06dd21
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1093862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487745
Reviewed-by: Fergal Daly <fergal@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819275}
  • Loading branch information
nidhijaju authored and Commit Bot committed Oct 21, 2020
1 parent 41488e3 commit be460e5
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 18 deletions.
4 changes: 2 additions & 2 deletions third_party/blink/renderer/core/streams/transform_stream.idl
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
[CallWith=ScriptState, RaisesException] constructor(optional any transformer,
optional any writableStrategy,
optional any readableStrategy);
readonly attribute ReadableStream readable;
readonly attribute WritableStream writable;
[NotEnumerable] readonly attribute ReadableStream readable;
[NotEnumerable] readonly attribute WritableStream writable;
};
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@

// https://streams.spec.whatwg.org/#rs-default-controller-class-definition
interface TransformStreamDefaultController {
readonly attribute double? desiredSize;
[CallWith=ScriptState, RaisesException] void enqueue(
[NotEnumerable] readonly attribute double? desiredSize;
[CallWith=ScriptState, NotEnumerable, RaisesException] void enqueue(
optional any chunk);
[CallWith=ScriptState] void error(optional any reason);
[CallWith=ScriptState] void terminate();
[CallWith=ScriptState, NotEnumerable] void error(optional any reason);
[CallWith=ScriptState, NotEnumerable] void terminate();
};
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
This is a testharness.js-based test.
Found 224 tests; 138 PASS, 86 FAIL, 0 TIMEOUT, 0 NOTRUN.
Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup
PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
Expand Down Expand Up @@ -176,8 +176,8 @@ PASS TransformStream interface object name
PASS TransformStream interface: existence and properties of interface prototype object
PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property
PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property
PASS TransformStream interface: attribute readable
PASS TransformStream interface: attribute writable
FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false
FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false
PASS TransformStream must be primary interface of new TransformStream()
PASS Stringification of new TransformStream()
PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
This is a testharness.js-based test.
Found 224 tests; 138 PASS, 86 FAIL, 0 TIMEOUT, 0 NOTRUN.
Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup
PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
Expand Down Expand Up @@ -176,8 +176,8 @@ PASS TransformStream interface object name
PASS TransformStream interface: existence and properties of interface prototype object
PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property
PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property
PASS TransformStream interface: attribute readable
PASS TransformStream interface: attribute writable
FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false
FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false
PASS TransformStream must be primary interface of new TransformStream()
PASS Stringification of new TransformStream()
PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
This is a testharness.js-based test.
Found 224 tests; 138 PASS, 86 FAIL, 0 TIMEOUT, 0 NOTRUN.
Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup
PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
Expand Down Expand Up @@ -176,8 +176,8 @@ PASS TransformStream interface object name
PASS TransformStream interface: existence and properties of interface prototype object
PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property
PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property
PASS TransformStream interface: attribute readable
PASS TransformStream interface: attribute writable
FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false
FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false
PASS TransformStream must be primary interface of new TransformStream()
PASS Stringification of new TransformStream()
PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
This is a testharness.js-based test.
Found 224 tests; 138 PASS, 86 FAIL, 0 TIMEOUT, 0 NOTRUN.
Found 224 tests; 126 PASS, 98 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup
PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
Expand Down Expand Up @@ -176,8 +176,8 @@ PASS TransformStream interface object name
PASS TransformStream interface: existence and properties of interface prototype object
PASS TransformStream interface: existence and properties of interface prototype object's "constructor" property
PASS TransformStream interface: existence and properties of interface prototype object's @@unscopables property
PASS TransformStream interface: attribute readable
PASS TransformStream interface: attribute writable
FAIL TransformStream interface: attribute readable assert_true: property should be enumerable expected true got false
FAIL TransformStream interface: attribute writable assert_true: property should be enumerable expected true got false
PASS TransformStream must be primary interface of new TransformStream()
PASS Stringification of new TransformStream()
PASS TransformStream interface: new TransformStream() must inherit property "readable" with the proper type
Expand Down

0 comments on commit be460e5

Please sign in to comment.