Skip to content

Commit

Permalink
Reland "Remove NotEnumerable from Writable Streams WebIDL"
Browse files Browse the repository at this point in the history 
This is a reland of a2505c5

Original change's description:
> Remove NotEnumerable from Writable Streams WebIDL
>
> According to whatwg/streams#1035, all methods
> and accessors are now enumerable, per Web IDL defaults, instead of
> non-enumerable, per ECMAScript defaults. Hence, 'NotEnumerable' can
> be removed from the Streams WebIDL files. This CL specifically
> removes them from writable streams.
>
> Bug: 1093862
> Change-Id: I935a9f8726b3cb1dc4efb5b4d6db71384c8efe37
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485664
> Reviewed-by: Adam Rice <ricea@chromium.org>
> Commit-Queue: Nidhi Jaju <nidhijaju@google.com>
> Cr-Commit-Position: refs/heads/master@{#819181}

Bug: 1093862
Change-Id: Iaf54f395cc649b85cbc834dc18baf94855d53613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489110
Commit-Queue: Nidhi Jaju <nidhijaju@google.com>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819563}
  • Loading branch information
@nidhijaju
nidhijaju authored and Commit Bot committed Oct 21, 2020
1 parent 974e1b6 commit 3927561
Show file tree
Hide file tree
Showing 7 changed files with 60 additions and 60 deletions.
8 changes: 4 additions & 4 deletions third_party/blink/renderer/core/streams/writable_stream.idl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
Exposed=(Window,Worker,Worklet)
] interface WritableStream {
[CallWith=ScriptState, RaisesException, MeasureAs=WritableStreamConstructor] constructor(optional any underlyingSink, optional any strategy);
[NotEnumerable] readonly attribute boolean locked;
[RaisesException, CallWith=ScriptState, NotEnumerable] Promise<void> abort(
readonly attribute boolean locked;
[RaisesException, CallWith=ScriptState] Promise<void> abort(
optional any reason);
[RaisesException, CallWith=ScriptState, NotEnumerable] Promise<void> close();
[RaisesException, CallWith=ScriptState, NotEnumerable] WritableStreamDefaultWriter getWriter();
[RaisesException, CallWith=ScriptState] Promise<void> close();
[RaisesException, CallWith=ScriptState] WritableStreamDefaultWriter getWriter();
};
2 changes: 1 addition & 1 deletion third_party/blink/renderer/core/streams/writable_stream_default_controller.idl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@

// https://streams.spec.whatwg.org/#ws-default-controller-class-definition
interface WritableStreamDefaultController {
[CallWith=ScriptState, NotEnumerable] void error(optional any e);
[CallWith=ScriptState] void error(optional any e);
};
14 changes: 7 additions & 7 deletions third_party/blink/renderer/core/streams/writable_stream_default_writer.idl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,17 @@
Exposed=(Window,Worker,Worklet)
] interface WritableStreamDefaultWriter {
[CallWith=ScriptState, RaisesException] constructor(WritableStream stream);
[CallWith=ScriptState, NotEnumerable] readonly attribute Promise<void>
[CallWith=ScriptState] readonly attribute Promise<void>
closed;
[RaisesException, CallWith=ScriptState, NotEnumerable] readonly attribute
[RaisesException, CallWith=ScriptState] readonly attribute
any desiredSize;
[CallWith=ScriptState, NotEnumerable] readonly attribute Promise<void>
[CallWith=ScriptState] readonly attribute Promise<void>
ready;

[CallWith=ScriptState, RaisesException, NotEnumerable] Promise<void> abort(
[CallWith=ScriptState, RaisesException] Promise<void> abort(
optional any reason);
[CallWith=ScriptState, RaisesException, NotEnumerable] Promise<void> close();
[CallWith=ScriptState, NotEnumerable] void releaseLock();
[CallWith=ScriptState, RaisesException, NotEnumerable] Promise<void> write(
[CallWith=ScriptState, RaisesException] Promise<void> close();
[CallWith=ScriptState] void releaseLock();
[CallWith=ScriptState, RaisesException] Promise<void> write(
optional any chunk);
};
24 changes: 12 additions & 12 deletions third_party/blink/web_tests/external/wpt/streams/idlharness.any-expected.txt
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
This is a testharness.js-based test.
Found 224 tests; 128 PASS, 96 FAIL, 0 TIMEOUT, 0 NOTRUN.
Found 224 tests; 139 PASS, 85 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup
PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
Expand Down Expand Up @@ -124,10 +124,10 @@ PASS WritableStream interface object name
PASS WritableStream interface: existence and properties of interface prototype object
PASS WritableStream interface: existence and properties of interface prototype object's "constructor" property
PASS WritableStream interface: existence and properties of interface prototype object's @@unscopables property
FAIL WritableStream interface: attribute locked assert_true: property should be enumerable expected true got false
FAIL WritableStream interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
FAIL WritableStream interface: operation close() assert_true: property should be enumerable expected true got false
FAIL WritableStream interface: operation getWriter() assert_true: property should be enumerable expected true got false
PASS WritableStream interface: attribute locked
PASS WritableStream interface: operation abort(optional any)
PASS WritableStream interface: operation close()
PASS WritableStream interface: operation getWriter()
PASS WritableStream must be primary interface of new WritableStream()
PASS Stringification of new WritableStream()
PASS WritableStream interface: new WritableStream() must inherit property "locked" with the proper type
Expand All @@ -141,13 +141,13 @@ PASS WritableStreamDefaultWriter interface object name
PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object
PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's "constructor" property
PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's @@unscopables property
FAIL WritableStreamDefaultWriter interface: attribute closed assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: attribute desiredSize assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: attribute ready assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation close() assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation releaseLock() assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation write(optional any) assert_true: property should be enumerable expected true got false
PASS WritableStreamDefaultWriter interface: attribute closed
PASS WritableStreamDefaultWriter interface: attribute desiredSize
PASS WritableStreamDefaultWriter interface: attribute ready
PASS WritableStreamDefaultWriter interface: operation abort(optional any)
PASS WritableStreamDefaultWriter interface: operation close()
PASS WritableStreamDefaultWriter interface: operation releaseLock()
PASS WritableStreamDefaultWriter interface: operation write(optional any)
PASS WritableStreamDefaultWriter must be primary interface of (new WritableStream()).getWriter()
PASS Stringification of (new WritableStream()).getWriter()
PASS WritableStreamDefaultWriter interface: (new WritableStream()).getWriter() must inherit property "closed" with the proper type
Expand Down
24 changes: 12 additions & 12 deletions third_party/blink/web_tests/external/wpt/streams/idlharness.any.serviceworker-expected.txt
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
This is a testharness.js-based test.
Found 224 tests; 128 PASS, 96 FAIL, 0 TIMEOUT, 0 NOTRUN.
Found 224 tests; 139 PASS, 85 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup
PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
Expand Down Expand Up @@ -124,10 +124,10 @@ PASS WritableStream interface object name
PASS WritableStream interface: existence and properties of interface prototype object
PASS WritableStream interface: existence and properties of interface prototype object's "constructor" property
PASS WritableStream interface: existence and properties of interface prototype object's @@unscopables property
FAIL WritableStream interface: attribute locked assert_true: property should be enumerable expected true got false
FAIL WritableStream interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
FAIL WritableStream interface: operation close() assert_true: property should be enumerable expected true got false
FAIL WritableStream interface: operation getWriter() assert_true: property should be enumerable expected true got false
PASS WritableStream interface: attribute locked
PASS WritableStream interface: operation abort(optional any)
PASS WritableStream interface: operation close()
PASS WritableStream interface: operation getWriter()
PASS WritableStream must be primary interface of new WritableStream()
PASS Stringification of new WritableStream()
PASS WritableStream interface: new WritableStream() must inherit property "locked" with the proper type
Expand All @@ -141,13 +141,13 @@ PASS WritableStreamDefaultWriter interface object name
PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object
PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's "constructor" property
PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's @@unscopables property
FAIL WritableStreamDefaultWriter interface: attribute closed assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: attribute desiredSize assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: attribute ready assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation close() assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation releaseLock() assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation write(optional any) assert_true: property should be enumerable expected true got false
PASS WritableStreamDefaultWriter interface: attribute closed
PASS WritableStreamDefaultWriter interface: attribute desiredSize
PASS WritableStreamDefaultWriter interface: attribute ready
PASS WritableStreamDefaultWriter interface: operation abort(optional any)
PASS WritableStreamDefaultWriter interface: operation close()
PASS WritableStreamDefaultWriter interface: operation releaseLock()
PASS WritableStreamDefaultWriter interface: operation write(optional any)
PASS WritableStreamDefaultWriter must be primary interface of (new WritableStream()).getWriter()
PASS Stringification of (new WritableStream()).getWriter()
PASS WritableStreamDefaultWriter interface: (new WritableStream()).getWriter() must inherit property "closed" with the proper type
Expand Down
24 changes: 12 additions & 12 deletions third_party/blink/web_tests/external/wpt/streams/idlharness.any.sharedworker-expected.txt
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
This is a testharness.js-based test.
Found 224 tests; 128 PASS, 96 FAIL, 0 TIMEOUT, 0 NOTRUN.
Found 224 tests; 139 PASS, 85 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup
PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
Expand Down Expand Up @@ -124,10 +124,10 @@ PASS WritableStream interface object name
PASS WritableStream interface: existence and properties of interface prototype object
PASS WritableStream interface: existence and properties of interface prototype object's "constructor" property
PASS WritableStream interface: existence and properties of interface prototype object's @@unscopables property
FAIL WritableStream interface: attribute locked assert_true: property should be enumerable expected true got false
FAIL WritableStream interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
FAIL WritableStream interface: operation close() assert_true: property should be enumerable expected true got false
FAIL WritableStream interface: operation getWriter() assert_true: property should be enumerable expected true got false
PASS WritableStream interface: attribute locked
PASS WritableStream interface: operation abort(optional any)
PASS WritableStream interface: operation close()
PASS WritableStream interface: operation getWriter()
PASS WritableStream must be primary interface of new WritableStream()
PASS Stringification of new WritableStream()
PASS WritableStream interface: new WritableStream() must inherit property "locked" with the proper type
Expand All @@ -141,13 +141,13 @@ PASS WritableStreamDefaultWriter interface object name
PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object
PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's "constructor" property
PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's @@unscopables property
FAIL WritableStreamDefaultWriter interface: attribute closed assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: attribute desiredSize assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: attribute ready assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation close() assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation releaseLock() assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation write(optional any) assert_true: property should be enumerable expected true got false
PASS WritableStreamDefaultWriter interface: attribute closed
PASS WritableStreamDefaultWriter interface: attribute desiredSize
PASS WritableStreamDefaultWriter interface: attribute ready
PASS WritableStreamDefaultWriter interface: operation abort(optional any)
PASS WritableStreamDefaultWriter interface: operation close()
PASS WritableStreamDefaultWriter interface: operation releaseLock()
PASS WritableStreamDefaultWriter interface: operation write(optional any)
PASS WritableStreamDefaultWriter must be primary interface of (new WritableStream()).getWriter()
PASS Stringification of (new WritableStream()).getWriter()
PASS WritableStreamDefaultWriter interface: (new WritableStream()).getWriter() must inherit property "closed" with the proper type
Expand Down
24 changes: 12 additions & 12 deletions third_party/blink/web_tests/external/wpt/streams/idlharness.any.worker-expected.txt
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
This is a testharness.js-based test.
Found 224 tests; 128 PASS, 96 FAIL, 0 TIMEOUT, 0 NOTRUN.
Found 224 tests; 139 PASS, 85 FAIL, 0 TIMEOUT, 0 NOTRUN.
PASS idl_test setup
PASS idl_test validation
PASS ReadableStreamDefaultReader includes ReadableStreamGenericReader: member names are unique
Expand Down Expand Up @@ -124,10 +124,10 @@ PASS WritableStream interface object name
PASS WritableStream interface: existence and properties of interface prototype object
PASS WritableStream interface: existence and properties of interface prototype object's "constructor" property
PASS WritableStream interface: existence and properties of interface prototype object's @@unscopables property
FAIL WritableStream interface: attribute locked assert_true: property should be enumerable expected true got false
FAIL WritableStream interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
FAIL WritableStream interface: operation close() assert_true: property should be enumerable expected true got false
FAIL WritableStream interface: operation getWriter() assert_true: property should be enumerable expected true got false
PASS WritableStream interface: attribute locked
PASS WritableStream interface: operation abort(optional any)
PASS WritableStream interface: operation close()
PASS WritableStream interface: operation getWriter()
PASS WritableStream must be primary interface of new WritableStream()
PASS Stringification of new WritableStream()
PASS WritableStream interface: new WritableStream() must inherit property "locked" with the proper type
Expand All @@ -141,13 +141,13 @@ PASS WritableStreamDefaultWriter interface object name
PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object
PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's "constructor" property
PASS WritableStreamDefaultWriter interface: existence and properties of interface prototype object's @@unscopables property
FAIL WritableStreamDefaultWriter interface: attribute closed assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: attribute desiredSize assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: attribute ready assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation abort(optional any) assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation close() assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation releaseLock() assert_true: property should be enumerable expected true got false
FAIL WritableStreamDefaultWriter interface: operation write(optional any) assert_true: property should be enumerable expected true got false
PASS WritableStreamDefaultWriter interface: attribute closed
PASS WritableStreamDefaultWriter interface: attribute desiredSize
PASS WritableStreamDefaultWriter interface: attribute ready
PASS WritableStreamDefaultWriter interface: operation abort(optional any)
PASS WritableStreamDefaultWriter interface: operation close()
PASS WritableStreamDefaultWriter interface: operation releaseLock()
PASS WritableStreamDefaultWriter interface: operation write(optional any)
PASS WritableStreamDefaultWriter must be primary interface of (new WritableStream()).getWriter()
PASS Stringification of (new WritableStream()).getWriter()
PASS WritableStreamDefaultWriter interface: (new WritableStream()).getWriter() must inherit property "closed" with the proper type
Expand Down

0 comments on commit 3927561

Please sign in to comment.