Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Build manylinux1 wheels #108

Closed
wants to merge 1 commit into from
Closed

Conversation

xhochy
Copy link
Collaborator

@xhochy xhochy commented Jun 28, 2017

Depends on pypa/auditwheel#76

@codecov-io
Copy link

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files         140      140           
  Lines        2392     2392           
=======================================
  Hits         2341     2341           
  Misses         51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c73d64...6a52ebf. Read the comment docs.

@MathMagique
Copy link
Member

Relates to #89

@yaxxie
Copy link
Contributor

yaxxie commented Sep 7, 2017

Hi guys,

I was working on manually grafting a manylinux wheel for distribution within my org. I noticed this as well (and decided it as acceptable), but I am just wondering what it is about pyarrow that auditwheel wants to graft libarrow_python.so, and yet it doesn't want to graft the numpy libraries. It makes me wonder if it is more an issue with the way pyarrow is built and perhaps there is something that should be changed upstream there instead?

On the other hand, I struggled with the RPATH for the other shared objects that point to libturbodbc.so because once their RPATH is updated for the vendored shared objects, libturbodbc.so is no longer in the RPATH and is not found at runtime. I am working around this by hardlinking libturbodbc.so into the vendor paths at the same time as hardlinking the vendored shared objects for libturbodbc.so (because libodbc.so.2 and libltdl.so.3 are not being vendored for this one), as well as fixing a libname change which doesn't look like it worked correctly against turbodbc_intern.so.

I got a working (import turbodbc works, didn't test properly) manylinux wheel like this, which is obviously fugly, but I'm wondering if you have any tips or comments to add?

@yaxxie
Copy link
Contributor

yaxxie commented Sep 7, 2017

I guess I should try your dockerfile that I never noticed ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants