Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Copy signing keys to /etc/ only #288

Merged
merged 4 commits into from
Dec 8, 2024
Merged

Conversation

fiftydinar
Copy link
Contributor

@fiftydinar fiftydinar commented Dec 7, 2024

Supplements main PR: blue-build/modules#375

Tests & it works, can be merged.

gmpinder
gmpinder previously approved these changes Dec 7, 2024
Copy link
Member

@gmpinder gmpinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but it seems like the signing module is causing failures. I think that will have to be updated before this can be merged in.

@fiftydinar
Copy link
Contributor Author

fiftydinar commented Dec 7, 2024

The changes look good, but it seems like the signing module is causing failures. I think that will have to be updated before this can be merged in.

Edit: Ublue-os key shouldn't be copied as a replacement to the image key & that file doesn't exist anyway. Idk where it got from in that code.
I'll just error the build out if .pub key is not copied.

@fiftydinar
Copy link
Contributor Author

It would be good to use the signing module from my PR temporarily to test this, then revert it back.
Is that good?

@fiftydinar
Copy link
Contributor Author

fiftydinar commented Dec 7, 2024

It would be good to use the signing module from my PR temporarily to test this, then revert it back. Is that good?

I confirm it works now, so it can be merged.

@gmpinder gmpinder enabled auto-merge (rebase) December 8, 2024 21:31
@gmpinder gmpinder disabled auto-merge December 8, 2024 21:33
@gmpinder gmpinder enabled auto-merge (rebase) December 8, 2024 21:37
@gmpinder
Copy link
Member

gmpinder commented Dec 8, 2024

It would be good to use the signing module from my PR temporarily to test this, then revert it back. Is that good?

I confirm it works now, so it can be merged.

I'm not comfortable merging this in until blue-build/modules#375 is merged. I run my builds of the main branch and this will fail them without the module changes.

@fiftydinar
Copy link
Contributor Author

It would be good to use the signing module from my PR temporarily to test this, then revert it back. Is that good?

I confirm it works now, so it can be merged.

I'm not comfortable merging this in until blue-build/modules#375 is merged. I run my builds of the main branch and this will fail them without the module changes.

Merged

@gmpinder gmpinder disabled auto-merge December 8, 2024 22:07
@gmpinder gmpinder merged commit 273d879 into blue-build:main Dec 8, 2024
9 of 15 checks passed
@fiftydinar fiftydinar deleted the patch-1 branch December 8, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants