Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: link to download badge #37

Merged
merged 1 commit into from
Aug 31, 2024
Merged

add: link to download badge #37

merged 1 commit into from
Aug 31, 2024

Conversation

blooop
Copy link
Owner

@blooop blooop commented Aug 31, 2024

Summary by Sourcery

Add a hyperlink to the PyPI downloads badge in the README to enhance user access to download statistics.

Documentation:

  • Add a hyperlink to the PyPI downloads badge in the README to direct users to the package's download statistics page.

Copy link

sourcery-ai bot commented Aug 31, 2024

Reviewer's Guide by Sourcery

This pull request adds a clickable link to the PyPI downloads badge in the README.md file. The change enhances the user experience by allowing direct access to the package download statistics on PyPI Stats.

File-Level Changes

Change Details Files
Added a hyperlink to the PyPI downloads badge
  • Wrapped the existing PyPI downloads badge with a markdown link
  • Set the link destination to the PyPI Stats page for the deps-rocker package
README.md

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @blooop - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -7,7 +7,7 @@
[![GitHub issues](https://img.shields.io/github/issues/blooop/deps_rocker.svg)](https://GitHub.com/blooop/deps_rocker/issues/)
[![GitHub pull-requests merged](https://badgen.net/github/merged-prs/blooop/deps_rocker)](https://github.com/blooop/deps_rocker/pulls?q=is%3Amerged)
[![GitHub release](https://img.shields.io/github/release/blooop/deps_rocker.svg)](https://GitHub.com/blooop/deps_rocker/releases/)
![PyPI - Downloads](https://img.shields.io/pypi/dm/deps-rocker)
[![PyPI - Downloads](https://img.shields.io/pypi/dm/deps-rocker)](https://pypistats.org/packages/deps-rocker)
[![License](https://img.shields.io/pypi/l/bencher)](https://opensource.org/license/mit/)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (documentation): License badge appears to be for a different project.

The license badge currently shows information for 'bencher' instead of 'deps_rocker'. Consider updating this to reflect the correct project.

@blooop blooop merged commit 9530179 into main Aug 31, 2024
7 checks passed
@blooop blooop deleted the feature/downloads_badge_link branch August 31, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant