Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat[bmq]: Add interfaces in DTTracer to serialize and deserialize span #627

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

emelialei88
Copy link
Collaborator

No description provided.

@emelialei88 emelialei88 marked this pull request as ready for review February 21, 2025 19:43
@emelialei88 emelialei88 requested a review from a team as a code owner February 21, 2025 19:43
@emelialei88 emelialei88 force-pushed the feat/extend-dt branch 4 times, most recently from a9e8653 to 44b0c34 Compare February 21, 2025 20:21
@emelialei88 emelialei88 marked this pull request as draft February 21, 2025 20:32
@pniedzielski
Copy link
Collaborator

Let's be careful about when we merge this, because it's a breaking change to the plugin interface. We should definitely call attention to this.

@emelialei88 emelialei88 force-pushed the feat/extend-dt branch 3 times, most recently from 43552f5 to b63f56f Compare February 24, 2025 16:20
@emelialei88 emelialei88 marked this pull request as ready for review February 24, 2025 17:04
Copy link
Collaborator

@pniedzielski pniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be very careful with when we merge this change, as I noted above. A few comments on the interface:

@emelialei88 emelialei88 force-pushed the feat/extend-dt branch 4 times, most recently from 3dd233f to 153f850 Compare February 24, 2025 22:21
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
Copy link
Collaborator

@pniedzielski pniedzielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We'll schedule the merge to minimize churn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants