-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat[bmq]: Add interfaces in DTTracer to serialize and deserialize span #627
base: main
Are you sure you want to change the base?
Conversation
44edc55
to
7e6bf70
Compare
a9e8653
to
44b0c34
Compare
Let's be careful about when we merge this, because it's a breaking change to the plugin interface. We should definitely call attention to this. |
43552f5
to
b63f56f
Compare
b63f56f
to
e1cd45e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be very careful with when we merge this change, as I noted above. A few comments on the interface:
e1cd45e
to
0df4e6c
Compare
3dd233f
to
153f850
Compare
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
153f850
to
10015d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We'll schedule the merge to minimize churn.
No description provided.