Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: check C++03 standard build #626

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

CI: check C++03 standard build #626

wants to merge 39 commits into from
+187 −103

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Feb 21, 2025 •
edited
Loading

The new c++03 build workflow can catch accidental usage of features not supported by solaris compiler, for example:

/home/runner/work/blazingmq/blazingmq/src/groups/bmq/bmqu/bmqu_blob.cpp:588:19: error: ‘ret’ does not name a type
  588 |     auto          ret = findOffset(&end, blob, start, length);

@678098
CI: check old standard build
e65c8d7 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098 678098 requested a review from a team as a code owner February 21, 2025 08:29
678098 added 11 commits February 21, 2025 08:36
@678098
Update build.yaml
eccf7f5 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update build.yaml
cea87a4 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update build.yaml
d25a069 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqu_blob.cpp
6b2b18e 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update build.yaml
197ecce 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update build.yaml
ec5405a 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update build.yaml
b5cb4c7 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update build.yaml
9b29aaa 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update build.yaml
d25a756 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update build.yaml
a39fff2 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqu_blob.cpp
032937a 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098 678098 changed the title CI: check old standard build CI: check C++03 standard build Feb 21, 2025
678098 added 16 commits February 21, 2025 10:17
@678098
Update bmqtst_testhelper.h
1fe7504 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqc_array.t.cpp
bd1eb76 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqc_monitoredqueue_bdlccfixedqueue.t.cpp
fd931ef 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqc_monitoredqueue_bdlccsingleconsumerqueue.t.cpp
5d8cd23 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqc_multiqueuethreadpool.t.cpp
91cffb5 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqc_orderedhashmap.t.cpp
ae9ef03 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqeval_simpleevaluator.t.cpp
03f2ad3 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqma_countingallocator.t.cpp
7624f74 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqp_compression.t.cpp
b74ac66 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqp_crc32c.t.cpp
b45bf8a 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqp_messageguidgenerator.t.cpp
d27e1cb 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqsys_time.t.cpp
9b09053 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update mqbs_datastore.t.cpp
2476be7 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update mqbu_messageguidutil.t.cpp
e83be04 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update mqbu_storagekey.t.cpp
f23e932 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqtst_testhelper.h
efb09d7 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
678098 added 10 commits February 21, 2025 10:41
@678098
Update bmqtst_testhelper.h
a70bea6 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqtst_testhelper.h
355bfa2 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqeval_simpleevaluator.t.cpp
d113c20 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqex_executor.t.cpp
89ba765 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqex_executor.t.cpp
b44b25b 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqex_executor.t.cpp
84ca66d 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update bmqex_executortraits.t.cpp
bf70dea 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update build.yaml
da4bc79 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update mqbnet_tcpsessionfactory.cpp
ef94ae7 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
@678098
Update mqbnet_tcpsessionfactory.cpp
659b452 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
hallfox
hallfox previously approved these changes Feb 21, 2025
View reviewed changes
@678098
Update build_deps.sh
cf4c188 
Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallfox hallfox hallfox left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@678098 @hallfox