Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix[IT]: add domain consistency coverage #610

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

alexander-e1off
Copy link
Collaborator

Closes #543

The following changes are introduced to cover domain consistency in integration tests

  • Added new optional pytest command line argument:
--domain-consistency={eventual,strong,both}
                      run with domain consistency: <eventual>, strong or both

which is used for tests parameterization to define domain consistency (by default eventual).

  • If it is needed to test method for different domain consistencies
    (eventual, strong or both), optional argument domain_urls should
    be passed. It should be used instead of direct using DOMAIN_* and URI_*
    constants (except DOMAIN_BROADCAST/URI_BROADCAST):
    def test_post_message_priority(self, cluster, 
                                   domain_urls: tc.DomainUrls):
        du = domain_urls
        self.producer.open(
            du.uri_priority, flags=['write', 'ack'], succeed=True)
        self.producer.post(
            du.uri_priority, payload=[payload], succeed=True, wait_ack=True)
  • When integration test is running, consistency argument is shown in parametrization, e.g.
test_admin_client.py::test_queue_stats[single_node_fsm-eventual_consistency] PASSED
test_admin_client.py::test_queue_stats[single_node_fsm-strong_consistency] PASSED

@alexander-e1off alexander-e1off changed the title [IT] add domain consistency coverageAdd domain consistency coverage Fix[IT] add domain consistency coverageAdd domain consistency coverage Feb 13, 2025
@alexander-e1off alexander-e1off marked this pull request as ready for review February 14, 2025 09:51
@alexander-e1off alexander-e1off requested a review from a team as a code owner February 14, 2025 09:51
@alexander-e1off alexander-e1off changed the title Fix[IT] add domain consistency coverageAdd domain consistency coverage Fix[IT] add domain consistency coverage Feb 14, 2025
@alexander-e1off alexander-e1off changed the title Fix[IT] add domain consistency coverage Fix[IT]: add domain consistency coverage Feb 14, 2025
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Signed-off-by: Aleksandr Ivanov <aivanov71@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests should cover both strong and eventual consistency domains
2 participants