feat repair CSL on mismatch with Domain config #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorjesinpo
changed the title
dorjesinpo
force-pushed
the
fix/repair-csl
branch
from
5456c92 to
a8cf24c
Compare
dorjesinpo
changed the title
dorjesinpo
force-pushed
the
fix/repair-csl
branch
from
a8cf24c to
d32c263
Compare
hallfox
reviewed
Feb 5, 2025
Comment on lines
2851
to
2852
| bsl::vector<bsl::string> addedIds(d_allocator_p); | ||
| bsl::vector<bsl::string> removedIds(d_allocator_p); |
There was a problem hiding this comment.
I think we should prefer the default allocator for this, the object that will technically own this memory is the function wrapper coming from bind, which is allocated using the default allocator. Providing this class's allocator might just lead to fragmentation.
There was a problem hiding this comment.
Interesting. I guess, the best would be to pass bsl::shared_ptr<bsl::vector<bsl::string>> to avoid unnecessary copying
| @@ -235,6 +236,7 @@ ClusterQueueHelper::QueueLiveState::QueueLiveState( | |||
| , d_numHandleCreationsInProgress(other.d_numHandleCreationsInProgress) | |||
| , d_queueExpirationTimestampMs(other.d_queueExpirationTimestampMs) | |||
| , d_pending(other.d_pending) | |||
| , d_pendingUpdates(other.d_pendingUpdates) | |||
There was a problem hiding this comment.
Suggested change
| , d_pendingUpdates(other.d_pendingUpdates) | |
| , d_pendingUpdates(other.d_pendingUpdates, allocator) |
dorjesinpo
force-pushed
the
fix/repair-csl
branch
from
d32c263 to
b034bcd
Compare
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
dorjesinpo
force-pushed
the
fix/repair-csl
branch
2 times, most recently
from
43e86fe to
baa5767
Compare
Signed-off-by: dorjesinpo <129227380+dorjesinpo@users.noreply.github.com>
dorjesinpo
force-pushed
the
fix/repair-csl
branch
from
baa5767 to
c11fc4e
Compare
![bmq-oss-ci[bot]](https://avatars.githubusercontent.com/u/1416818?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rely on Primary to pick new domain config, but if Primary fails, the new config does not make it to the CSL on existing Replica.
As the result new Primary may crash because domain config doe snot match CSL -