Cancel openbook v2 order by client order id #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farnyser
reviewed
Jun 5, 2024
| // Check instruction gate. Guarded by the same as cancelling by exchange id. | ||
| let group = ctx.accounts.group.load()?; | ||
| require!( | ||
| group.is_ix_enabled(IxGate::OpenbookV2CancelOrder), |
There was a problem hiding this comment.
For perp we have a dedicated ix_gate for cancel by client id, maybe add one here ?
There was a problem hiding this comment.
could if you want. dont do it in serum3 though.
would require duplicating the account_ix file because it would be a new constraint
There was a problem hiding this comment.
ok can probably keep like this, thx
programs/mango-v4/src/instructions/openbook_v2_cancel_order_by_client_order_id.rs
Show resolved
Hide resolved
farnyser
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to cancel orders to openbook v2 using the client order id so they dont have to keep track of exchange order ids