liquidator: forcefully exit process if snapshot job die #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microwavedcola1
approved these changes
Mar 27, 2024
ckamm
reviewed
Apr 1, 2024
lib/client/src/snapshot_source.rs
Outdated
| tokio::spawn(async move { | ||
| let res = snapshot_job.await; | ||
| tracing::error!("Snapshot job exited, terminating process.. ({:?})", res); | ||
| std::process::exit(-1); |
There was a problem hiding this comment.
While this works technically, the previous pattern was to collect all the essential jobs in main and do the "something aborted, exit" logic there. I'd prefer that to be consistent.
Secondly, while this addresses the issue with the snapshot job dying unnoticed, the underlying issue is the .expect() on the result of the get_epoch_info rpc call, as far as I remember. Since it's only affecting startup, I'm ok with the restart-to-retry approach for now though.
…y unexpected exit
ckamm
approved these changes
Apr 1, 2024
farnyser
added a commit
that referenced
this pull request
Apr 4, 2024
* liquidator: forcefully exit process if snapshot job die * client: return snapshot_job join handle so it can be watched for early unexpected exit (cherry picked from commit 2520c7d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.