Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openbook V2 Integration #836

Merged
merged 116 commits into from
Apr 22, 2024
Merged

Openbook V2 Integration #836

merged 116 commits into from
Apr 22, 2024

Conversation

riordanp
Copy link
Contributor

@riordanp riordanp commented Jan 4, 2024 •
edited by ckamm
Loading

ckamm's pending:

  • is there a program test for obv2_settle?
  • would be good to have a test for reading old account data with borsh and zerocopy? (moved to tests: Check mango account backwards compatibility #878 )
  • tests don't pass right now
  • one obv2 program test still commented out until program fix and .so update
  • liquidator needs to be updated to force cancel obv2 orders

@riordanp riordanp requested a review from ckamm January 4, 2024 11:09
ckamm
ckamm reviewed Jan 4, 2024
View reviewed changes
lib/client/src/health_cache.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/accounts_ix/openbook_v2_place_order.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/health/account_retriever.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/health/account_retriever.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/health/account_retriever.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/health/cache.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/health/cache.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/state/mango_account.rs Show resolved Hide resolved
programs/mango-v4/src/state/mango_account_components.rs Outdated Show resolved Hide resolved
programs/mango-v4/tests/cases/test_alt.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added dependency Dependency updates program On-chain program changes client TS client changes labels Jan 8, 2024
ckamm
ckamm reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@ckamm ckamm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MangoAccount::expected_health_accounts() needs an update for obv2 EDIT: done

ckamm
ckamm reviewed Jan 10, 2024
View reviewed changes
programs/mango-v4/src/instructions/openbook_v2_register_market.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/instructions/openbook_v2_edit_market.rs Show resolved Hide resolved
programs/mango-v4/src/instructions/openbook_v2_register_market.rs Show resolved Hide resolved
programs/mango-v4/src/instructions/openbook_v2_register_market.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/instructions/openbook_v2_register_market.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/instructions/openbook_v2_place_order.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/instructions/openbook_v2_place_order.rs Show resolved Hide resolved
programs/mango-v4/src/lib.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/instructions/openbook_v2_place_order.rs Outdated Show resolved Hide resolved
programs/mango-v4/src/instructions/openbook_v2_place_order.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added documentation Improvements or additions to documentation devops DevOps changes labels Apr 18, 2024
@ckamm ckamm changed the title WIP: Openbook V2 Integration Openbook V2 Integration Apr 18, 2024
ckamm
ckamm approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@ckamm ckamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending issues:

  • fix bug in openbook v2 program, update fixture, uncomment test code
  • test liquidator, maybe write obv2_liq_force_cancel program test

ckamm and others added 8 commits April 18, 2024 12:11
@ckamm
wip: integration test for obv2 liq force cancel
7988087
@ckamm
Fix obv2 liq force close instruction and add test
22a1145
@farnyser
Serge/obv2 small fixes (#947)
67383f3 
* program: openbook v2 - change some data layout
* program: openbook v2 - change param order for coherence with openbook v1
@microwavedcola1
create obv2 market script
2cf1023 
Signed-off-by: microwavedcola1 <microwavedcola@gmail.com>
@ckamm
tests: update obv2 fixture and tests
8d9413e 
obv2 sha1: 8928d4cb23efe4864fc05aab9f00519eacf83720
@ckamm
bump to v0.25.0, update idl, add idl-compare exceptions
33ac9b4
@microwavedcola1
fix linting issues
61df0a2 
Signed-off-by: microwavedcola1 <microwavedcola@gmail.com>
@ckamm
yarn deduplicate
25bca83
@ckamm ckamm marked this pull request as ready for review April 22, 2024 09:36
@ckamm ckamm merged commit 2a6532f into dev Apr 22, 2024
25 of 26 checks passed
@ckamm ckamm deleted the pan/openbook-v2 branch April 22, 2024 09:37
@riordanp riordanp restored the pan/openbook-v2 branch May 21, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckamm ckamm ckamm approved these changes

Assignees
No one assigned
Labels
client TS client changes dependency Dependency updates devops DevOps changes documentation Improvements or additions to documentation program On-chain program changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@riordanp @ckamm @tlrjs @farnyser @microwavedcola1