feat(fv): add semantic analysis for fv attributes #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smanilov
approved these changes
Sep 19, 2024
| @@ -1381,4 +1395,75 @@ impl<'context> Elaborator<'context> { | |||
| _ => true, | |||
| }) | |||
| } | |||
|
|
|||
| fn elaborate_fv_attributes( | |||
There was a problem hiding this comment.
Suggested change
| fn elaborate_fv_attributes( | |
| /// Performs semantic analysis on the formal verification attributes discovered by the parser. | |
| /// | |
| /// `fv_attributes` - the parsed attributes | |
| /// `func_id` - this is the `FuncId` of the function to which the attributes are attached | |
| /// `body_type` - this is the semantically inferred type of the expression that is the body of the function | |
| /// `hir_func` - this identifies the same expression | |
| /// `func_span` - represents the span in code | |
| fn elaborate_fv_attributes( |
There was a problem hiding this comment.
Please, also figure out what's the correct way to cite parameters in a doccomment in Rust (rustdoc).
There was a problem hiding this comment.
Citing parameters is not a part of rustdoc anymore. Source: rust-lang/rust-by-example#1804 .
Still, I will add old style comments for the arguments.
Added name resolution and type checking for the expression bodies of the formal verification attributes. This means that functions in HIR now have resolved formal verification attributes attached to them. Added tests which showcase the newly added functionality.
Aristotelis2002
force-pushed
the
semantic-fv-support
branch
from
0a03406
to
49382b4
Compare
Aristotelis2002
added a commit
that referenced
this pull request
Sep 20, 2024
Formal verification attributes are now ignored in all other (non fv) nargo cli commands and won't produce any errors related to semantic analysis. Also expanded the testing logic. Now there are two directories for testing formal verification functionality. Them being `formal_verify_failure` and `formal_verify_success`. Moved the tests from PR #88 in their matching directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added name resolution and type checking for the expression bodies of the formal verification attributes. This means that functions in HIR now have resolved formal verification attributes attached to them.
Added tests which showcase the newly added functionality.