Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add native token image #1932

Merged
merged 3 commits into from
May 24, 2024
Merged

add native token image #1932

merged 3 commits into from
May 24, 2024

Conversation

isstuev
Copy link
Collaborator

@isstuev isstuev commented May 17, 2024

Description and Related Issue(s)

resolves #1381

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

@isstuev isstuev changed the title Fe 1381 main add native token image May 17, 2024
@isstuev isstuev marked this pull request as ready for review May 17, 2024 13:37
@isstuev isstuev requested a review from tom2drum May 17, 2024 15:48
@github-actions github-actions bot added the enhancement New feature or request label May 17, 2024
Copy link
Collaborator

@tom2drum tom2drum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a mock for this icon to some tests to ensure it will be displayed in the UI.

ui/shared/entities/token/TokenEntity.tsx Outdated Show resolved Hide resolved
@isstuev isstuev force-pushed the fe-1381-main branch 2 times, most recently from 9f3621e to 4580fdc Compare May 23, 2024 21:56
@tom2drum tom2drum merged commit 2a18290 into main May 24, 2024
7 checks passed
@tom2drum tom2drum deleted the fe-1381-main branch May 24, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token icon (stats section homepage)
3 participants