Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Blockscout page banner height bug fix and new changes/New tooltips for Block Details page added/ Token image added to the Token instance page. #2625

Closed
wants to merge 10 commits into from

Conversation

YegorSan
Copy link
Contributor

Issues introduced at :

Motivation

  • Add tooltips to the "Block Details" page #1771 - New Tooltips were needed for the Block Details page.
  • ERC-721 token instance page #2541 - ERC-721 token instance page required some changes. I've added a new block with the image into the Total Supply container. As content is rendering dynamically - we still must add some additional logic for Total Supply container ( if token type ERC721 => return new created div with image and hide text info). As for tabs - still need similar logical solution ( if token type ERC721 => hide unnecessary tabs from the page).
  • Top banner on the Blockscout home page is opening with the height bug now. I've added several changes in order to fix this issue (fixed height etc.) .

Changelog

Enhancements

Bug Fixes

Fixed height bug with top banner container on the main BlockScout Page:

  • Was:

Запись_экрана_2019-08-14_в_19 50 21

  • Now:

AwesomeScreenshot-2019-8-20-1566309626893

Additional Note

Please let me know how to create a new entry to CHANGELOG.md with current PR correctly . I've made a reset of some commits in my local forked repo - as I've accidentally pushed some unnecessary changes . So based on the foregoing info - this latest commit is including multiple changes inside. Next time i will make each commit separately, sorry for my mistake.

Checklist for your PR

@vbaranov vbaranov requested a review from ayrat555 August 27, 2019 09:58
@igorbarinov igorbarinov requested review from vbaranov and removed request for ayrat555 August 27, 2019 09:58
@vbaranov vbaranov requested review from saneery, ayrat555 and pasqu4le and removed request for vbaranov August 27, 2019 09:58
@igorbarinov igorbarinov requested review from vbaranov and saneery and removed request for saneery and pasqu4le August 27, 2019 09:58
@vbaranov vbaranov requested a review from pasqu4le August 27, 2019 10:06
@ayrat555
Copy link
Contributor

please run mix gettext.extract --merge to fix gettext

@vbaranov
Copy link
Member

please run mix gettext.extract --merge to fix gettext

@YegorSan just to clarify: it should be executed from ./apps/block_scout_web folder. Here is the guide https://poanetwork.github.io/blockscout/#/internationalization?id=internationalization

@ayrat555
Copy link
Contributor

btw ERC721 token instance page does not exist yet. You added an image to ERC721 token overview page

@YegorSan YegorSan closed this Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants